Skip to content

InkRecognizer to use GA azure-core - #8341

Merged
kristapratico merged 2 commits into
masterfrom
ink_rec_ga_core
Nov 15, 2019
Merged

InkRecognizer to use GA azure-core#8341
kristapratico merged 2 commits into
masterfrom
ink_rec_ga_core

Conversation

@lmazuel

@lmazuel lmazuel commented Nov 1, 2019

Copy link
Copy Markdown
Member

No description provided.

@lmazuel lmazuel added Cognitive Services Client This issue points to a problem in the data-plane of the library. labels Nov 1, 2019
@lmazuel
lmazuel requested review from johanste and xinyzhou November 1, 2019 16:30
@lmazuel
lmazuel requested a review from mayurid as a code owner November 1, 2019 16:30
@xinyzhou

xinyzhou commented Nov 1, 2019

Copy link
Copy Markdown
Contributor

The second commit from AutorestCI did some weird things, e.g. changing package name (sdk/cognitiveservices/azure-cognitiveservices-inkrecognizer/setup.py Line 16), changing filename to refer (sdk/cognitiveservices/azure-cognitiveservices-inkrecognizer/setup.py Line 24), create separate and incorrect readme (sdk/cognitiveservices/azure-cognitiveservices-inkrecognizer/Readme.rst), etc.
Is there any way that we can manually ban the Auto commit, or revert it?

@AutorestCI

AutorestCI commented Nov 1, 2019

Copy link
Copy Markdown
Contributor

(message created by the CI based on PR content)

Installation instruction

Package azure-cognitiveservices-inkrecognizer

You can install the package azure-cognitiveservices-inkrecognizer of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@ink_rec_ga_core#egg=azure-cognitiveservices-inkrecognizer&subdirectory=azure-cognitiveservices-inkrecognizer"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@ink_rec_ga_core#egg=azure-cognitiveservices-inkrecognizer&subdirectory=azure-cognitiveservices-inkrecognizer"

If you have a local clone of this repository, you can also do:

  • git checkout ink_rec_ga_core
  • pip install -e ./azure-cognitiveservices-inkrecognizer

Or build a wheel file to distribute for testing:

  • git checkout ink_rec_ga_core
  • pip wheel --no-deps ./azure-cognitiveservices-inkrecognizer

Direct download

Your files can be directly downloaded here:

@lmazuel

lmazuel commented Nov 1, 2019

Copy link
Copy Markdown
Member Author

@xinyzhou yes you're right, the DevOps system pushed an incorrect auto-commit, I fixed it with a "push force" and disabled auto-commit system for this package. We should be good now :)

@lmazuel lmazuel changed the title InkRecognizer to use Ga azure-core InkRecognizer to use GA azure-core Nov 1, 2019
@xinyzhou

xinyzhou commented Nov 1, 2019

Copy link
Copy Markdown
Contributor

@lmazuel Cool, thanks!

@kristapratico
kristapratico merged commit 92f806c into master Nov 15, 2019
xiangyan99 added a commit that referenced this pull request Nov 15, 2019
* InteractiveBrowserCredential prompts for account selection (#8470)

* remove *.yaml under tests folder from manifest.in (#8625)

* [AutoPR] cosmos-db/resource-manager (#8560)

* regenerated

* fix script

* another place

* fix

* fix

* one more change

* one more

* undo multiapi script

* regeneated

* undo multiapi script

* history, version + additional fix

* regenerated

* fixed test

* fixed generation mistake

* added more breaking changes to history

* regenerated again

* additional fixes

* udpated test names

* test recordings

* Update README.md (#8628)

Add standard section on security issues below the "file an issue via GitHub Issues' bullet.

* Handle exceptions when constructing DefaultAzureCredential (#8294)

* Python 3.8 test pipeline is not cancelled when build is cancelled (#8544)

* Skip python 3.8 testing when CI is cancelled

* Cosmos docstring review (#8607)

* cosmos docstring edits

* user-defined

* trailing whitespace

* xfail flaky emulator tests

* review feedback

* Default credentials are configurable by kwargs (#8514)

* Nightly build is failing due version conflict between storage datalak… (#8635)

* Nightly build is failing due version conflict between storage datalake and storage blob

* InkRecognizer to use GA azure-core (#8341)

* InkRecognizer to use Ga azure-core

* Disable auto-pr update

* Azconfig remove tests from whl (#8663)

* update tests

* ignoring the azure folder directly (#8673)
@lmazuel
lmazuel deleted the ink_rec_ga_core branch May 15, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Cognitive Services

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants